fix: add visitedNFT to localstorage #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
roiLeo
reviewed
Mar 13, 2023
stores/history.ts
Outdated
Comment on lines
117
to
120
| localStorage.setItem( | ||
| 'history', | ||
| JSON.stringify({ history: { visitedNFTs: this.visitedNFTs } }) | ||
| ) |
There was a problem hiding this comment.
useStorage() might help (same stuff done in #5217)
|
Code Climate has analyzed commit b415f78 and detected 0 issues on this pull request. View more on Code Climate. |
preschian
requested review from
daiagi and
Jarsen136
and removed request for
a team
Jarsen136
approved these changes
Mar 13, 2023
vikiival
approved these changes
Mar 13, 2023
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
fix this error on localhost. how to reproduce: open gallery item in new tab